Re: Generating code for query jumbling through gen_node_support.pl - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Generating code for query jumbling through gen_node_support.pl
Date
Msg-id 3972105.1675984370@sss.pgh.pa.us
Whole thread Raw
In response to Re: Generating code for query jumbling through gen_node_support.pl  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Generating code for query jumbling through gen_node_support.pl
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> Tom, did you get a chance to look at what is proposed here and expand
> the use of query_jumble_ignore in the definitions of the nodes rather
> than have an enforced per-file policy in gen_node_support.pl?

Sorry, didn't look at it before.

I'm okay with the pathnodes.h changes --- although surely you don't need
changes like this:

-    pg_node_attr(abstract)
+    pg_node_attr(abstract, no_query_jumble)

"abstract" should already imply "no_query_jumble".

I wonder too if you could shorten the changes by making no_query_jumble
an inheritable attribute, and then just applying it to Path and Plan.

The changes in parsenodes.h seem wrong, except for RawStmt.  Those node
types are used in parsed queries, aren't they?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Importing pg_bsd_indent into our source tree
Next
From: Tom Lane
Date:
Subject: Re: Importing pg_bsd_indent into our source tree