Re: VM corruption on standby - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: VM corruption on standby
Date
Msg-id 3A177D8E-99D3-48E0-AD31-B2B12063CABF@yandex-team.ru
Whole thread Raw
In response to Re: VM corruption on standby  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

> On 17 Aug 2025, at 17:33, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> So I think the correct fix here is s/proc_exit(1)/_exit(2)/ in the
> places that are responding to postmaster death.

+1. But should we _exit(2) only in critical section or always in case of postmaster death?

Another question that was bothering Kirill is do we want a test that naturally reproduces WaitEventSetWaitBlock() under
criticalsection so that we can observe a corruption? Or is it kind of obvious from code that such things might happen? 
Existing test is adding WaitEventSetWaitBlock() via injection point to a place where it was not present before. Though
withexisting test at hand we can check that fix is curing WaitEventSetWaitBlock() against critical section. 


Best regards, Andrey Borodin.


pgsql-hackers by date:

Previous
From: Laurenz Albe
Date:
Subject: Re: analyze-in-stages post upgrade questions
Next
From: Michael Paquier
Date:
Subject: Re: [Proposal] Expose internal MultiXact member count function for efficient monitoring