Re: anonymous composite types for Table Functions (aka - Mailing list pgsql-patches

From Joe Conway
Subject Re: anonymous composite types for Table Functions (aka
Date
Msg-id 3D4DFCCA.6040907@joeconway.com
Whole thread Raw
In response to Re: anonymous composite types for Table Functions (aka SRFs)  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: anonymous composite types for Table Functions (aka SRFs)
List pgsql-patches
Tom Lane wrote:
> Hm.  I'd sort of expect the "z" to become both the table and column
> alias in this case.  What do you think?

I guess that would make sense. I'll make a separate patch just for that
change if that's OK.


> Other examples look good.  Code style comment:
>
>
>>+         if (functyptype != 'p' || (functyptype == 'p' && funcrettype != RECORDOID))
>
>
> This test seems redundant, why not
>
>         if (functyptype != 'p' || funcrettype != RECORDOID)
>

You're correct, of course. But I started out with a much more convoluted
test than that, so at least this was an improvement ;-)

Joe



pgsql-patches by date:

Previous
From: "Christopher Kings-Lynne"
Date:
Subject: Re: anonymous composite types for Table Functions (aka
Next
From: Joe Conway
Date:
Subject: Re: anonymous composite types for Table Functions (aka