Re: contrib/cube & contrib/seg regression fixes - Mailing list pgsql-patches

From Joe Conway
Subject Re: contrib/cube & contrib/seg regression fixes
Date
Msg-id 3D84125F.80408@joeconway.com
Whole thread Raw
In response to contrib/cube & contrib/seg regression fixes  (Joe Conway <mail@joeconway.com>)
Responses Re: contrib/cube & contrib/seg regression fixes
List pgsql-patches
Tom Lane wrote:
> AFAICT, bison 1.28 (what I have here) cannot emit any message mentioning
> "unexpected"; the word just plain does not appear in bison.simple.
> "unexpected $undefined." does not exactly seem like a major advance in
> error-message technology anyway :-(.
>
> I suggest we sit tight and hope that the bison guys get their act
> together, soon.

I figured as much. Thanks for looking at it.

FWIW, both seg and cube have "#define YYERROR_VERBOSE", which seems to add the
expected/unexpected text. It might solve the issue to remove the define and
accept slightly less verbose output.

As a side note, while researching this I looked at bison's cvs HEAD. It
appears bison is undergoing some fairly substantial rewriting -- bison.simple
is now in the attic.

Joe


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Patch to return last tid
Next
From: Tom Lane
Date:
Subject: Re: contrib/cube & contrib/seg regression fixes