Re: array support patch phase 1 patch - Mailing list pgsql-patches

From Joe Conway
Subject Re: array support patch phase 1 patch
Date
Msg-id 3EDE2C78.4060803@joeconway.com
Whole thread Raw
In response to Re: array support patch phase 1 patch  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: array support patch phase 1 patch
List pgsql-patches
Tom Lane wrote:
> BTW, it might be better for array_cmp to insist that the array element
> type have a default btree opclass, and use the comparison proc from that
> opclass in place of equality_oper() and ordering_oper().  This'd be
> faster (only one call per comparison) as well as more semantically pure.

Sounds like a good idea. Should I work this now, or wait for more comments?

> I've got some other problems with this patch (I still don't understand
> what the hacking on aggregates is supposed to accomplish, for example)

The aggregates hacking was a bit convoluted by the desire to support
polymorphic aggregates using polymorphic functions. You end up with many
possible states, some of which are invalid because they don't provide
enough context to resolve the polymorphic types. Any suggestions?

Joe




pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: array support patch phase 1 patch
Next
From: Tom Lane
Date:
Subject: Re: array support patch phase 1 patch