Re: more C99 cleanup - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: more C99 cleanup
Date
Msg-id 3b12679c-5282-4429-945d-fbb0639562ea@eisentraut.org
Whole thread Raw
In response to Re: more C99 cleanup  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 21.11.25 16:35, Tom Lane wrote:
> * In 0003, we can't be very sure what "isblank((unsigned char) c)"
> will do with non-ASCII input data, except that it could very
> easily do insane things with fragments of a multibyte character.
> I recommend keeping pg_isblank but redefining it along the lines of
> 
>     bool
>     pg_isblank(unsigned char c)
>     {
>         return (!IS_HIGHBIT_SET(c) && isblank(c));
>     }
> 
> to ensure the previous treatment of non-ASCII data.
> (It could be made static in hba.c, perhaps)

Ok, done that way.




pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication
Next
From: Michael Banck
Date:
Subject: Re: [PATCH] Expose checkpoint timestamp and duration in pg_stat_checkpointer