Re: Convert macros to static inline functions - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Convert macros to static inline functions
Date
Msg-id 3dfbd51a-ad90-4418-9c66-ec85d5a2cbdd@enterprisedb.com
Whole thread Raw
In response to Convert macros to static inline functions  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
On 27.12.24 11:16, Peter Eisentraut wrote:
> On 16.05.22 10:27, Peter Eisentraut wrote:
>> Inspired by [0], I looked to convert more macros to inline functions. 
> 
> This is an older thread where I left something unfinished:
> 
>> Note 2: Many macros in htup_details.h operate both on HeapTupleHeader 
>> and on MinimalTuple, so converting them to a function doesn't work in 
>> a straightforward way.  I have some in-progress work in that area, but 
>> I have not included any of that here.
> 
> Here is the patch set for this.

I have committed this.

> There are actually only two macros that operate on both HeapTupleHeader 
> and MinimalTuple, so it wasn't as much as I had written above.  I just 
> left those as macros.  I converted the rest to inline functions in a 
> straightforward way as before.  A small amount of reordering was necessary.
> 
> But just for language-nerd fun, I'm including here an additional patch 
> showing how the remaining ones could be done with C11 generic selection. 
>   I'm not planning to commit that one at this time.

... except this.




pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Pgoutput not capturing the generated columns
Next
From: Shlok Kyal
Date:
Subject: Re: Virtual generated columns