Re: contrib/xml2 function name change and minor bitrot - Mailing list pgsql-patches

From Neil Conway
Subject Re: contrib/xml2 function name change and minor bitrot
Date
Msg-id 404B89F2.2010700@samurai.com
Whole thread Raw
In response to contrib/xml2 function name change and minor bitrot fix  (John Gray <jgray@azuli.co.uk>)
Responses Re: contrib/xml2 function name change and minor bitrot
List pgsql-patches
John Gray wrote:
> I have changed the name of the new parse function to xml_valid and fixed
> a reference to SortMem which meant that the code as supplied would work
> against 7.3 and 7.4 but wouldn't work in CVS. Oops! Patch is attached.

Patch applied.

A few comments on the module:

- can you include some licensing information? "Distributed under the
same terms as PostgreSQL, Copyright ..." should be sufficient unless
you'd prefer another license

- some information on how to configure the location of the libxml2
headers / libs would be good, I think

- the readme for both 'contrib/xml' and 'contrib/xml2' is called
'README.pgxml', yet neither module is actually named 'pgxml'

-Neil

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: contrib/xml2 function name change and minor bitrot
Next
From: "Lee Kindness"
Date:
Subject: ECPG - Remove need for "AT connection" when using threads