Re: COMMENT ON [GROUP/USER] - Mailing list pgsql-hackers

From Mike Mascari
Subject Re: COMMENT ON [GROUP/USER]
Date
Msg-id 404CD581.2060206@mascari.com
Whole thread Raw
In response to Re: COMMENT ON [GROUP/USER]  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: COMMENT ON [GROUP/USER]
List pgsql-hackers
Andrew Dunstan wrote:
> Bruce Momjian wrote:
> 
>> Another problem is that pg_description is per-database, while
>> pg_user/group are global for all databases.
>>
>>  
>>
> databases are also per cluster, but we have comments on those.
> 
> Could we keep the user/group comments in those tables instead of in 
> pg_description?

The comments are stored only in the database's pg_description where 
the COMMENT ON took place. This caused dump/reload problems. I 
believe Rod Taylor added the new warning:

[estore@lexus] select count(*) from pg_description; count
-------  1541
(1 row)

[estore@lexus] COMMENT ON DATABASE test IS 'Hello';
WARNING:  database comments may only be applied to the current database
COMMENT

[estore@lexus] select count(*) from pg_description; count
-------  1541
(1 row)

[estore@lexus] COMMENT ON DATABASE estore IS 'A good comment';
COMMENT

[estore@lexus] select count(*) from pg_description; count
-------  1542
(1 row)

[test@lexus] select count(*) from pg_description; count
-------  1541
(1 row)


Mike Mascari



pgsql-hackers by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: socket calls in signal handler (WAS: APC + socket restrictions un der Win32?)
Next
From: Bruce Momjian
Date:
Subject: Re: COMMENT ON [GROUP/USER]