Re: selective statement logging - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: selective statement logging
Date
Msg-id 404F8DDD.5000602@dunslane.net
Whole thread Raw
In response to Re: selective statement logging  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: selective statement logging
List pgsql-hackers
Bruce Momjian wrote:

>Andrew Dunstan wrote:
>  
>
>>>Yes, look at how the command tag is grabbed for the PS display, and do
>>>the log checks at that point.
>>>
>>> 
>>>
>>>      
>>>
>>Yes, I thought about that. But it would delay the logging of statements, 
>>and I'm not sure that's a good idea. What would happen on parse errors, 
>>for example?
>>    
>>
>
>Well, if it is parse error, then we can't know what type of command it
>really was.  They could type 'SE9ECT 1' or 'SELECT 1 WH8RE x=1' and both
>are not really SELECT commands to me.
>
>  
>

If I delay logging until after the parse, these log lines would come out 
in reverse order. Not sure if that matters to anyone, but it might annoy 
me slightly.

line:3 LOG:  statement: se4dt ddd;
line:4 ERROR:  syntax error at or near "se4dt" at character 1

cheers

andrew



pgsql-hackers by date:

Previous
From: Hannu Krosing
Date:
Subject: Re: PITR Functional Design v2 for 7.5
Next
From: Dennis Bjorklund
Date:
Subject: unsafe floats