Postgres Pro
Downloads
Home   >   mailing lists

Re: compiling with RELCACHE_FORCE_RELEASE doesn't pass regression - Mailing list pgsql-hackers

From Tom Lane
Subject Re: compiling with RELCACHE_FORCE_RELEASE doesn't pass regression
Date
Msg-id 4361.1283386347@sss.pgh.pa.us
Whole thread Raw
In response to Re: compiling with RELCACHE_FORCE_RELEASE doesn't pass regression  (Jeff Davis <pgsql@j-davis.com>)
List pgsql-hackers
Tree view 
Jeff Davis <pgsql@j-davis.com> writes:
> I have attached regression.diffs after a "make check". The diffs don't
> look trivial, and actually look quite strange to me.

BTW, if I dike out the flush_rowtype_cache call at relcache.c:1929,
the regression tests do pass for me, so it seems there is only one
bug exposed by this test (as of HEAD anyway).  I don't find that
to be a credible real fix, though, as stated previously.

Once we do have a fix in place for this, it might be a good idea for
someone to run a buildfarm member with -DRELCACHE_FORCE_RELEASE ...
        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Fix for pg_upgrade's forcing pg_controldata into English
Next
From: KaiGai Kohei
Date:
Subject: security hook on table creation