Re: Cygwin PostgreSQL Regression Test Problems - Mailing list pgsql-ports

From Tom Lane
Subject Re: Cygwin PostgreSQL Regression Test Problems
Date
Msg-id 4370.979844016@sss.pgh.pa.us
Whole thread Raw
In response to Re: Cygwin PostgreSQL Regression Test Problems  (Jason Tishler <Jason.Tishler@dothill.com>)
Responses Re: Cygwin PostgreSQL Regression Test Problems
List pgsql-ports
Jason Tishler <Jason.Tishler@dothill.com> writes:
> /* FIXME: this delqueue module is very flawed and should be rewritten.
>         First, having an array of a fixed size for keeping track of the
>         unlinked but not yet deleted files is bad.  Second, some programs
>         will unlink files and then create a new one in the same location
>         and this behavior is not supported in the current code.  Probably
>         we should find a move/rename function that will work on open files,
>         and move delqueue files to some special location or some such
>         hack... */

> With the above caveats, is the current functionality sufficient for
> PostgreSQL's needs?

The fixed-size-array thing sounds like a gotcha waiting to bite someone.
How big is the array, anyway?

The unlink/recreate issue is not a problem for us anymore, since we use
OIDs as filenames --- we won't try to reuse the same filename.

            regards, tom lane

pgsql-ports by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Re: Cygwin PostgreSQL Regression Test Problems
Next
From: Yaacov Akiba Slama
Date:
Subject: Pg or DBD::Pg in cygwin 1.1.17