Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump? - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?
Date
Msg-id 447c2cf1-9b93-4869-95a4-78efee23f3fb@dunslane.net
Whole thread Raw
In response to why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?  (Srinath Reddy <srinath2133@gmail.com>)
List pgsql-hackers
On 2025-01-23 Th 3:18 AM, Srinath Reddy wrote:
> Hi,
>
> in pg_restore archive format option is parsed using only the first 
> character of the value but in pg_dump the archive format option's 
> value is compared with whole string using pg_strcasecmp is there any 
> specific reason?
>
>


`git blame` tells me that this switch statement goes back to 2001. 
Seeking a reason at this distance is unlikely to be productive. Probably 
we were not nearly as careful then as we are now about such things. Feel 
free to submit a patch tightening the test.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Orphaned users in PG16 and above can only be managed by Superusers
Next
From: Tomas Vondra
Date:
Subject: Re: Extended Statistics set/restore/clear functions.