Re: Weird test mixup - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Weird test mixup
Date
Msg-id 44f5bf13-b46e-4b87-84de-2ac70fddbda0@iki.fi
Whole thread Raw
In response to Re: Weird test mixup  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Weird test mixup
List pgsql-hackers
On 15/03/2024 01:13, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> Or we could just disable runningcheck because of the concurrency
>> requirement in this test.  The test would still be able to run, just
>> less times.
> 
> No, actually we *must* mark all these tests NO_INSTALLCHECK if we
> stick with the current definition of injection points.  The point
> of installcheck mode is that the tests are supposed to be safe to
> run in a live installation.  Side-effects occurring in other
> databases are completely not OK.

I committed a patch to do that, to put out the fire.

-- 
Heikki Linnakangas
Neon (https://neon.tech)




pgsql-hackers by date:

Previous
From: Jelte Fennema-Nio
Date:
Subject: Re: Possibility to disable `ALTER SYSTEM`
Next
From: Dean Rasheed
Date:
Subject: Re: MERGE ... RETURNING