Heikki Linnakangas wrote:
> Stefan Kaltenbrunner wrote:
>> Bruce Momjian wrote:
>>> Log Message:
>>> -----------
>>> Reduce WAL activity for page splits:
>>>
>>>> Currently, an index split writes all the data on the split page to
>>>> WAL. That's a lot of WAL traffic. The tuples that are copied to the
>>>> right page need to be WAL logged, but the tuples that stay on the
>>>> original page don't.
>>
>>
>> this patch killed both of my OpenBSD buildfarm members
>
> lopaque was referenced after pfreeing the temp page it pointed to. Also
> later in the function the LSN of the left page was set, but again using
> a pointer to the pfreed temp copy instead of the real shared memory buffer.
>
> Here's a fix.
confirmed - with that patch -HEAD passes a full regression test run at
least on emu.
Stefan
