Re: New version of GENERATED/IDENTITY, was Re: parser dilemma - Mailing list pgsql-patches

Thanks.

But actually it didn't showed up at that page.
For that matter, neither patch showed up on either pgpatches
or pgpatches_hold that you indicated yesterday.

Best regards,
Zoltán Böszörményi

Bruce Momjian írta:
> Your patch has been added to the PostgreSQL unapplied patches list at:
>
>     http://momjian.postgresql.org/cgi-bin/pgpatches
>
> It will be applied as soon as one of the PostgreSQL committers reviews
> and approves it.
>
> ---------------------------------------------------------------------------
>
>
> Zoltan Boszormenyi wrote:
>
>> Hi,
>>
>> some last changes. Really. :-)
>>
>> I made ALTER TABLE symmetric with CREATE TABLE
>> so the grammar now has:
>>
>> ALTER TABLE tabname ALTER colname SET GENERATED
>>    { ALWAYS | BY DEFAULT} AS IDENTITY [ ( sequence options )]
>>
>> This works intuitively the same as in CREATE TABLE, i.e.
>> - it creates an OWNED sequence (if the column doesn't already have one)
>> - it creates or alters the sequence with the given options
>> - adds the DEFAULT expression with the proper generation behaviour
>> in one go. I extended the documentation and modified the test case
>> accordingly.
>> I also tested that an IDENTITY column can't be created with a type that
>> cannot be cast from bigint i.e. box. I added it to the test case.
>>
>> Please, review.
>>
>> Best regards,
>> Zolt?n B?sz?rm?nyi
>>
>> Zoltan Boszormenyi ?rta:
>>
>>> And here it is attached. Sorry.
>>>
>>> Zoltan Boszormenyi ?rta:
>>>
>>>> Hi,
>>>>
>>>> here's the patch with the modifications suggested by Tom Lane.
>>>> The postfix rule was deleted from b_expr and the reverse parsing
>>>> in ruleutils.c::get_oper_expr() always puts parentheses around
>>>> postfix operators.
>>>>
>>>> Other changes:
>>>> - OVERRIDING SYSTEM VALUE in COPY can appear
>>>>   at any place in the option list.
>>>> - pg_dump was modified accordingly
>>>> - \copy built-in in psql now also accepts OVERRIDING SYSTEM VALUE
>>>> - documentation and testcase updates
>>>>
>>>> Please, review.
>>>>
>>>> Best regards,
>>>> Zolt?n B?sz?rm?nyi
>>>>
>>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>> ---------------------------(end of broadcast)---------------------------
>>> TIP 2: Don't 'kill -9' the postmaster
>>>
>>>
>> --
>> ----------------------------------
>> Zolt?n B?sz?rm?nyi
>> Cybertec Geschwinde & Sch?nig GmbH
>> http://www.postgresql.at/
>>
>>
>
> [ application/x-tar is not supported, skipping... ]
>
>


--
----------------------------------
Zoltán Böszörményi
Cybertec Geschwinde & Schönig GmbH
http://www.postgresql.at/