Re: Keyword list sanity check - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Keyword list sanity check
Date
Msg-id 49F6C4EF.2080807@enterprisedb.com
Whole thread Raw
In response to Re: Keyword list sanity check  (Greg Stark <greg.stark@enterprisedb.com>)
Responses Re: Keyword list sanity check
List pgsql-hackers
Greg Stark wrote:
> I had previously considered adding an assertion in the backend to check 
> they're sorted properly. That would be less formatting dependent and 
> would be only a couple lines of C.
> 
> I don't think we can do that with the gram.y check though.

Well, the ordering in gram.y is just pro forma anyway. Checking that all 
keywords are present and correctly labeled in kwlist.h is more 
important. What's still missing is to check that all keywords defined 
with "%token <keyword>" in gram.y are present in one of the keyword lists.

Hmm, it just occurred to me that this script is only a few steps away 
from actually generating kwlist.h from gram.y, instead of merely 
cross-checking them.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Keyword list sanity check
Next
From: Gevik Babakhani
Date:
Subject: view columns and pg_depend