> On 23 Jan 2025, at 13:19, vignesh C <vignesh21@gmail.com> wrote:
> When dumping from Postgres <=PG17 servers, the query generated for
> pubgencols_type incorrectly included the macro name instead of the
> macro value. This resulted in dump failures. This commit fixes the
> issue by correctly specifying the macro value in the query. The
> attached patch has the changes for the same.
I was just looking at the Xversion test failure on crake (which has the log
entry below) when I saw your email.
pg_dump: error: query failed: ERROR: column "publish_gencols_none" does not exist
LINE 1: ...elete, false AS pubtruncate, false AS pubviaroot, PUBLISH_GE...
^
pg_dump: detail: Query was: SELECT p.tableoid, p.oid, p.pubname, p.pubowner, p.puballtables, p.pubinsert, p.pubupdate,
p.pubdelete,false AS pubtruncate, false AS pubviaroot, PUBLISH_GENCOLS_NONE AS pubgencols_type FROM pg_publication p
pg_dumpall: error: pg_dump failed on database "template1", exiting
Your patch seems like a reasonable fix.
--
Daniel Gustafsson
