Re: pgsql: Coerce 'unknown' type parameters to the right type in the - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Coerce 'unknown' type parameters to the right type in the
Date
Msg-id 4C6BF646.1030200@enterprisedb.com
Whole thread Raw
In response to Re: pgsql: Coerce 'unknown' type parameters to the right type in the  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 18/08/10 16:57, Tom Lane wrote:
> heikki@postgresql.org (Heikki Linnakangas) writes:
>> Log Message:
>> -----------
>> Coerce 'unknown' type parameters to the right type in the fixed-params
>> parse_analyze() function. That case occurs e.g with PL/pgSQL
>> EXECUTE ... USING 'stringconstant'.
>
>> The coercion with a CoerceViaIO node. The result is similar to the coercion
>> via input function performed for unknown constants in coerce_type(),
>> except that this happens at runtime.
>
> Unfortunately, this entirely fails to enforce the rule that an unknown
> Param be coerced the same way everywhere.  You'd need a cleanup pass as
> well, cf check_variable_parameters().

Yeah, you're right. I'll find a way to do the cleanup pass in fixed
params case too.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Coerce 'unknown' type parameters to the right type in the
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Add missing handling of PlannedStmt.transientPlan in