Re: refactoring comment.c - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: refactoring comment.c
Date
Msg-id 4C77E9410200002500034D8E@gw.wicourts.gov
Whole thread Raw
In response to Re: refactoring comment.c  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: refactoring comment.c
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> wrote:
> I suppose this is unhappy because it things elog(ERROR) might
> return?
It looks more like this code uses it without initialization:       case OBJECT_INDEX:       case OBJECT_SEQUENCE:
caseOBJECT_TABLE:       case OBJECT_VIEW:           relation =               get_relation_by_qualified_name(objtype,
objname,
lockmode);           address.classId = RelationRelationId;           address.objectId = RelationGetRelid(relation);
     address.objectSubId = 0;           break;
 
-Kevin


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: refactoring comment.c
Next
From: Robert Haas
Date:
Subject: Re: refactoring comment.c