Re: encode/decode support for base64url - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: encode/decode support for base64url
Date
Msg-id 4CA85654-D598-436F-B7AE-B5ECD2366F8E@yesql.se
Whole thread Raw
In response to Re: encode/decode support for base64url  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: encode/decode support for base64url
List pgsql-hackers
> On 17 Sep 2025, at 19:51, Masahiko Sawada <sawada.mshk@gmail.com> wrote:

> Thank you for updating the patch! I've done additional tests in my
> environment and all test cases passed. One very minor comment is that
> we might want to add 'BASE64URL' to:
>
> /*
> * BASE64
> */

I did that, and polished a few comments which had various version of case on
"base64url".  The RFC only mentions it in all lowercase so I went with that
apart from the in the comment mentioned above.

The attached v9 has this and

> Overall, the patch looks good to me. I'll wait for Daniel as he has
> polished this patch and might have some comments or want to take it.

Agreed, I think this is ready to go in.  If you want to push it then feel free,
else I'll take care of it tomorrow.

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Updating IPC::Run in CI?
Next
From: Nathan Bossart
Date:
Subject: fix obsolete references to postgres.h in comments