Re: fixing INT64_FORMAT warnings on Mingw - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: fixing INT64_FORMAT warnings on Mingw
Date
Msg-id 4DB825D4.9030000@dunslane.net
Whole thread Raw
In response to Re: fixing INT64_FORMAT warnings on Mingw  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers

On 04/27/2011 09:00 AM, Peter Eisentraut wrote:
> On Wed, 2011-04-27 at 00:01 -0400, Andrew Dunstan wrote:
>> Both "%lld" and "%I64d" can be used with mingw to print 64 bit integers.
>> However, modern versions of gcc spit warnings with the former, and not
>> the latter. However, since "%lld" works, it is chosen by our config
>> setup since it comes first in the list of formats tried. Therefore, to
>> keep the compiler happy I proposed to rearrange that so that "%I64d" is
>> preferred if it's found to work.
> We should prefer the standard syntax (%lld) over nonstandard ways.
> There could just as well be platforms that accept %I64d but warn about
> it (as being nonstandard).
>
> If that doesn't work for a specific platform, either adjust the test so
> that it checks for warnings, or just manually override the result in
> pg_config_os.h.
>

I did it that way.

cheers

andrew


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Best way to construct Datum out of a string?
Next
From: Tom Lane
Date:
Subject: Re: unknown conversion %m