Re: Identifying function-lookup failures due to argument name mismatches - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Identifying function-lookup failures due to argument name mismatches
Date
Msg-id 4ec76052-8614-4733-b417-5ce476fb0e15@eisentraut.org
Whole thread Raw
In response to Re: Identifying function-lookup failures due to argument name mismatches  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 24.08.25 20:47, Tom Lane wrote:
> Here is a v4 with some additional bike-shedding on the error texts.
> In particular, I decided that it was worth expending an additional
> flag bit so that we could reliably distinguish "There is no function
> of that name" from "A function of that name exists, but it is not in
> the search_path".  (Since FuncnameGetCandidates is already searching
> the entire set of functions matching the given name, it doesn't take
> any extra work to know that there's a match outside the search path.)
> I rephrased a couple of the other messages too, but without any
> substantive logic change.

I only gave it a quick review right now.  I have also been wanting to 
make the function lookup error messages more specific, so I like this 
direction very much.  The wording of the messages looks good and more 
useful than before.



pgsql-hackers by date:

Previous
From: Xuneng Zhou
Date:
Subject: Re: Improve read_local_xlog_page_guts by replacing polling with latch-based waiting
Next
From: Peter Eisentraut
Date:
Subject: Re: Identifying function-lookup failures due to argument name mismatches