Re: pg_upgrade problem with invalid indexes - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: pg_upgrade problem with invalid indexes
Date
Msg-id 50C140F4.5080204@dunslane.net
Whole thread Raw
In response to Re: pg_upgrade problem with invalid indexes  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: pg_upgrade problem with invalid indexes
List pgsql-hackers
On 12/06/2012 07:58 PM, Jeff Davis wrote:
> On Thu, 2012-12-06 at 16:31 -0800, Josh Berkus wrote:
>>> There are a few possible fixes.  The first would be to have pg_upgrade
>>> throw an error on any invalid index in the old cluster.  Another option
>>> would be to preserve the invalid state in pg_dump --binary-upgrade.
>> Or to not dump invalid indexes at all in --binary-upgrade mode.
> +1
>
>     

I think I prefer the first suggestion. If they are trying to upgrade 
when there's an invalid index presumably they aren't aware of the 
invalidity (or they would have done something about it). It would be 
better to fail and make them fix or remove the index, ISTM.

cheers

andrew




pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: pg_upgrade problem with invalid indexes
Next
From: Stephen Frost
Date:
Subject: Re: Commits 8de72b and 5457a1 (COPY FREEZE)