Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode
Date
Msg-id 53165764.6020004@dunslane.net
Whole thread Raw
In response to Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode
List pgsql-hackers
On 03/03/2014 06:48 AM, Michael Paquier wrote:
> On Mon, Mar 3, 2014 at 1:13 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
>>>> That difference actually made the file_fdw regression results plain
>>>> wrong,
>>>> in my view, in that they expected a quoted empty string to be turned to
>>>> null
>>>> even when the null string was something else.
>>>>
>>>> I've adjusted this and the docs and propose to apply the attached patch
>>>> in
>>>> the next day or two unless there are any objections.
>>> Unless I'm overlooking something, output from "SELECT * FROM text_csv;"
>>> in 'output/file_fdw.source' still needs updating?
> While reading this patch, I found a small typo in copy2.[sql|out] =>
> s/violiaton/violation/g


I have picked this up and committed the patch. Thanks to all.


cheers

andrew






pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe
Next
From: Tom Lane
Date:
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe Reply-To: