Re: Patch: Remove gcc dependency in definition of inline functions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Patch: Remove gcc dependency in definition of inline functions
Date
Msg-id 5376.1260981643@sss.pgh.pa.us
Whole thread Raw
In response to Re: Patch: Remove gcc dependency in definition of inline functions  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Patch: Remove gcc dependency in definition of inline functions
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Tom Lane escribi�:
>> I think you're way overthinking this.  Where we started was just
>> a proposal to try to expand the set of inline-ing compilers beyond
>> "gcc only".  I don't see why we need to do anything but that.  The
>> code is fine as-is except for the control #ifdefs.

> IIRC Kurt was also on about getting rid of some ugly macros that could
> instead be coded as inline functions (fastgetattr for example)

I'd just bounce that as useless activity.  If they are macros now,
and work, the only possible effects of changing them are negative.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [ADMIN] recovery is stuck when children are not processing SIGQUIT from previous crash
Next
From: Greg Smith
Date:
Subject: Re: PostgreSQL project policy compendium