Re: refactoring comment.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: refactoring comment.c
Date
Msg-id 5414.1282233440@sss.pgh.pa.us
Whole thread Raw
In response to Re: refactoring comment.c  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: refactoring comment.c
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Excerpts from Robert Haas's message of mié ago 18 21:32:48 -0400 2010:
>> Here's v3.

> The header comment in objectaddress.c contains a funny mistake: it says
> it works with ObjectAddresses.  However, ObjectAddresses is a different
> type altogether, so I recommend not using that as plural for
> ObjectAddress.  Maybe "ObjectAddress objects"?  :-D

Alternatively, maybe ObjectAddresses was a bad choice of type name,
and it should be ObjectAddressList or ObjectAddressArray or some such.
But changing that might be more trouble than it's worth.
        regards, tom lane


pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: Fw: patch for pg_ctl.c to add windows service start-type
Next
From: Robert Haas
Date:
Subject: Re: refactoring comment.c