Re: pgsql: Fix pg_size_bytes() to be more portable. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix pg_size_bytes() to be more portable.
Date
Msg-id 5432.1455980047@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Fix pg_size_bytes() to be more portable.  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: pgsql: Fix pg_size_bytes() to be more portable.
List pgsql-committers
Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> Fix pg_size_bytes() to be more portable.
> Commit 53874c5228fe16589a4d01b3e1fab3678e0fd8e3 broke various 32-bit
> buildfarm machines because it incorrectly used an 'L' suffix for what
> needed to be a 64-bit literal. Thanks to Michael Paquier for helping
> to diagnose this.

That's still not right: not all compilers support "long long", and the
ones that don't won't have "LL" notation either.

Project style is to use something like "(uint64) 1024" instead.

            regards, tom lane


pgsql-committers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: pgsql: Add pg_size_bytes() to parse human-readable size strings.
Next
From: Dean Rasheed
Date:
Subject: Re: pgsql: Fix pg_size_bytes() to be more portable.