Re: Badly designed error reporting code in controldata_utils.c - Mailing list pgsql-hackers

From Joe Conway
Subject Re: Badly designed error reporting code in controldata_utils.c
Date
Msg-id 56DCA08A.3050807@joeconway.com
Whole thread Raw
In response to Badly designed error reporting code in controldata_utils.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Badly designed error reporting code in controldata_utils.c
List pgsql-hackers
On 03/06/2016 01:24 PM, Tom Lane wrote:
> * It's randomly unlike every single other place we've addressed the
> same problem.  Everywhere else in src/common does it like this:
>
> #ifndef FRONTEND
>         ereport(ERROR,
>                 (errcode(ERRCODE_PROGRAM_LIMIT_EXCEEDED),
>                  errmsg("out of memory")));
> #else
>         fprintf(stderr, _("out of memory\n"));
>         exit(EXIT_FAILURE);
> #endif
>
> and I think that's what this needs to do too, especially in view of the
> fact that there are only two places that would have to be fixed anyway.

Ok, will fix.

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Badly designed error reporting code in controldata_utils.c
Next
From: Thom Brown
Date:
Subject: Re: The plan for FDW-based sharding