Postgres Pro
Downloads
Home   >   mailing lists

Re: Odd system-column handling in postgres_fdw join pushdown patch - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Odd system-column handling in postgres_fdw join pushdown patch
Date
Msg-id 56FA2292.7040905@lab.ntt.co.jp
Whole thread Raw
In response to Re: Odd system-column handling in postgres_fdw join pushdown patch  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: Odd system-column handling in postgres_fdw join pushdown patch
List pgsql-hackers
Tree view 
On 2016/03/25 17:16, Etsuro Fujita wrote:
> The approach that we discussed would minimize the code for the FDW
> author to write, by providing the support functions you proposed.  I'll
> post a patch for that early next week.

I added two helper functions: GetFdwScanTupleExtraData and
FillFdwScanTupleSysAttrs.  The FDW author could use the former to get
info about system attributes other than ctids and oids in fdw_scan_tlist
during BeginForeignScan, and the latter to set values for these system
attributes during IterateForeignScan (InvalidTransactionId for
xmins/xmaxs, InvalidCommandId for cmins/cmaxs, and valid values for
tableoids).  Attached is a proposed patch for that.  I also slightly
simplified the changes to make_tuple_from_result_row and
conversion_error_callback made by the postgres_fdw join pushdown patch.
  What do you think about that?

Best regards,
Etsuro Fujita
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c.
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: IF (NOT) EXISTS in psql-completion