(2018/04/03 22:01), Etsuro Fujita wrote:
> Attached is an updated version of the patch. Patch
> foreign-routing-fdwapi-3.patch is created on top of patch
> postgres-fdw-refactoring-3.patch and the bug-fix patch [1].
One thing I noticed about patch foreign-routing-fdwapi-3.patch is this
bug: the server will crash when copying data into a foreign table that
doesn't support the proposed APIs (eg, file_fdw foreign tables). The
reason is that the patch doesn't perform CheckValidResultRel before that
operation in that case. So I modified the patch as such and added
regression tests for that.
Attached is an updated version of the patch set:
* As before, patch foreign-routing-fdwapi-4.patch is created on top of
patch postgres-fdw-refactoring-4.patch and the bug-fix patch [1].
* I revised comments, docs, and regression tests a bit further, but no
code changes other than the bug fix.
Best regards,
Etsuro Fujita
[1] https://www.postgresql.org/message-id/5ABA4074.1090500@lab.ntt.co.jp
