Re: pgsql: Get rid of the dedicated latch for signaling the startup process - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Get rid of the dedicated latch for signaling the startup process
Date
Msg-id 5c1f8a85-747c-7bf9-241e-dd467d8a3586@iki.fi
Whole thread Raw
In response to pgsql: Get rid of the dedicated latch for signaling the startup process  (Fujii Masao <fujii@postgresql.org>)
Responses Re: pgsql: Get rid of the dedicated latch for signaling the startup process
List pgsql-committers
On 04/11/2020 09:44, Fujii Masao wrote:
> Get rid of the dedicated latch for signaling the startup process.
> 
> This commit gets rid of the dedicated latch for signaling the startup
> process in favor of using its procLatch,  since that comports better
> with possible generic signal handlers using that latch.
> 
> Commit 1e53fe0e70 changed background processes so that they use standard
> SIGHUP handler. Like that, this commit also makes the startup process use
> standard SIGHUP handler to simplify the code.

This seems to have made buildfarm member 'elver' to segfault. I've got a 
hunch that setting recoveryWakeupLatch to NULL, when WakeupRecovery() 
doesn't check for NULL, is not OK. It's surprising that we're only 
seeing this on 'elver', though.

- Heikki



pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: pg_rewind: Replace the hybrid list+array data structure with sim
Next
From: Fujii Masao
Date:
Subject: Re: pgsql: Get rid of the dedicated latch for signaling the startup process