Re: Suppressing occasional failures in copy2 regression test - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Re: Suppressing occasional failures in copy2 regression test
Date
Msg-id 65937bea0906211006y4d0ecfbawebf3d7004cd2f077@mail.gmail.com
Whole thread Raw
In response to Re: Suppressing occasional failures in copy2 regression test  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Suppressing occasional failures in copy2 regression test
List pgsql-hackers
On Sat, Jun 20, 2009 at 2:06 AM, Alvaro Herrera <alvherre@commandprompt.com> wrote:
About the comment in chomp: did you try to use different values of $/?


Well, now that I have tried it, yes, setting $/ to '\r\n' does give me what I expected. Both expected and result files should have the same kind of line endings though.

I expected chomp() to "Do The Right Thing" and eat away '\r\n' too, not just '\n'; my mistake.

Anyway, changing $/ in the script does not seem to be much good for our test framework. Making sure that the expected and result files have a Unix style line endings would better stand the test of time.

Another limitation of this script I forgot to mention is that it barfs if the last line of the expected file is '?/unordered'. Adding it to TODO list.

Best regards,
--
Lets call it Postgres

EnterpriseDB      http://www.enterprisedb.com

gurjeet[.singh]@EnterpriseDB.com
singh.gurjeet@{ gmail | hotmail | indiatimes | yahoo }.com
Mail sent from my BlackLaptop device

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: 8.4 open item: copy performance regression?
Next
From: Heikki Linnakangas
Date:
Subject: Re: 8.4 open item: copy performance regression?