Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Fix another instance of unsafe coding for shm_toc_lookup failure - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix another instance of unsafe coding for shm_toc_lookup failure
Date
Msg-id 6686.1517800529@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix another instance of unsafe coding for shm_toc_lookup failure  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-committers
Tree view 
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Sat, Feb 3, 2018 at 3:08 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> OK.  Please send in a patch to either do that or switch this call to use
>> noError = false.  Or possibly both: shouldn't there be some other signal
>> path that tells the worker whether instrumentation is needed?  I'll
>> leave it alone pending your investigation.

> Here's a patch do to both.

LGTM, pushed.

            regards, tom lane

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Skip setting up shared instrumentation for Hash node if notneed
Next
From: Tom Lane
Date:
Subject: pgsql: Fix RelationBuildPartitionKey's processing of partition keyexpr