Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT
Date
Msg-id 671136a1-f15e-4caa-ac5d-0e05e29dd754@iki.fi
Whole thread Raw
List pgsql-hackers
On 19/11/2024 01:20, Masahiko Sawada wrote:
> I realized that building test_radixtree.c with TEST_SHARED_RT fails
> because it eventually sets RT_SHMEM when #include'ing radixtree.h but
> it's missing some header files to include. I've attached a patch to
> include necessary header files in radixtree.h to make it
> self-contained.

+1. Please make sure the #includes are in alphabetical order.

While we're at it, I noticed that lib/radixtree.h includes "postgres.h". 
That's against our usual convention.

-- 
Heikki Linnakangas
Neon (https://neon.tech)




pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Reduce TupleHashEntryData struct size by half
Next
From: Masahiko Sawada
Date:
Subject: Re: Parallel heap vacuum