Re: benign bug in BufFileLoadBuffer / incorrect sizeof - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: benign bug in BufFileLoadBuffer / incorrect sizeof
Date
Msg-id 6847F153-2700-4B22-9068-901D37CD5D2F@yesql.se
Whole thread Raw
List pgsql-hackers
> On 12 Jan 2025, at 17:10, Tomas Vondra <tomas@vondra.me> wrote:
> 
> Hi,
> 
> While experimenting with some changes in BufFile, I noticed a harmless
> bug in BufFileLoadBuffer. It calls sizeof on the whole PGAlignedBuffer,
> instead of just on the "data" field. It's benign because the "data" is
> the largest part of the union, so the sizes are equal.
> 
> But it's still confusing, it took me a while my experimental patch
> fails. So I think it'd be good to correct it.

Nice catch, patch LGTM.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection