Re: [PATCH] Perform check for oversized WAL record before calculating record CRC - Mailing list pgsql-hackers

From Sergey Fukanchik
Subject Re: [PATCH] Perform check for oversized WAL record before calculating record CRC
Date
Msg-id 6ee042d1-7456-4732-b1e8-602b6beafb9a@postgrespro.ru
Whole thread Raw
In response to Re: [PATCH] Perform check for oversized WAL record before calculating record CRC  (Andrey Borodin <x4mmm@yandex-team.ru>)
List pgsql-hackers
> It seems to me reasonable to move size check above CRC computation. However, it seems suspicious to me to run a test
thatallocates 1Gb in `make check`. Maybe, there are places that are not exercised too often. Perhaps recovery tests or
somethinglike that.
 

Hi Andrey,

I share your concern about memory consumption and also agree recovery 
tests look like the right place for this test.

So I split the patch into two - the change proper and the converted TAP 
test, guarded by PG_TEST_EXTRA. Attaching both patches.

---

Sergey

Attachment

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: MergeAppend could consider sorting cheapest child path
Next
From: Zsolt Parragi
Date:
Subject: OAuth client code doesn't work with Google OAuth