Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section
Date
Msg-id 72d75070-8422-4796-9454-29ac2a8a4952@eisentraut.org
Whole thread Raw
In response to Moving the vacuum GUCs' docs out of the Client Connection Defaults section  (Melanie Plageman <melanieplageman@gmail.com>)
List pgsql-hackers
On 09.01.25 02:45, Melanie Plageman wrote:
> On Wed, Jan 8, 2025 at 8:39 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> On 07.01.25 18:31, Melanie Plageman wrote:
>>>
>>> Oh, one thing I forgot to say. Though I increased the indentation of
>>> some of the subsections that I moved, I didn't rewrap the lines
>>> because they were already not wrapped to 78. I can do this, but I
>>> can't tell from the existing docs what text width the paragraphs of
>>> text are supposed to be wrapped to.
>>
>> For a patch that moves things around like this, I would leave everything
>> as is and not rewrap.  That makes it easier to follow what's going on
>> with "git diff -w", "git show -w" etc.
>>
>> In .dir-locals.el, there is this configuration for Emacs:
>>
>>    (nxml-mode . ((fill-column . 78)
>>                  (indent-tabs-mode . nil)))
>>
>> So that's one data point about what the line length should be.
> 
> Well, in this case, the diff won't look different with git show/diff
> -w because moving them to another part of the file is more than a
> whitespace change.

Correct.  The right option is

     git diff --color-moved

This can also be put into .gitconfig.




pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: Adjusting hash join memory limit to handle batch explosion
Next
From: Andres Freund
Date:
Subject: Re: AIO v2.0