Re: Use more CppAsString2() in pg_amcheck.c - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Use more CppAsString2() in pg_amcheck.c
Date
Msg-id 7DBF8BF1-AFD8-4460-9F3B-5B15BA5FE3BA@yesql.se
Whole thread Raw
List pgsql-hackers
> On 18 Oct 2024, at 11:50, Michael Paquier <michael@paquier.xyz> wrote:

> pg_amcheck.c is one of these places where relkind and relpersistence
> values are hardcoded in queries based on the contents of pg_class_d.h.
> Similarly to other places in src/bin/, let's sprinkle some
> CppAsString2() and feed to the binary the values from the header.  The
> patch attached does that.

I haven't studied the patch in detail (yet), nothing stood out from a quick
skim, but +1 on the concept.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Conflict detection for update_deleted in logical replication
Next
From: Amit Kapila
Date:
Subject: Re: Enhance create subscription reference manual