Re: Old BufferDesc refcount in PrintBufferDescs and PrintPinnedBufs - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Old BufferDesc refcount in PrintBufferDescs and PrintPinnedBufs
Date
Msg-id 7gtfx2lc6surct3v6gbgo6e4nnymuvnsbbbizyryfrnnrikec6@heuvirlj52b5
Whole thread Raw
In response to Re: Old BufferDesc refcount in PrintBufferDescs and PrintPinnedBufs  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Old BufferDesc refcount in PrintBufferDescs and PrintPinnedBufs
List pgsql-hackers
Hi,

On 2025-01-19 09:37:54 +0900, Michael Paquier wrote:
> On Fri, Jan 17, 2025 at 11:14:02PM -0800, Jacob Brazeal wrote:
> > Sounds good! v3 attached.
> 
> Removal sounds good to me.  Any objections from anybody?
> 
> Andres, perhaps you have some experience using that and would prefer
> keep them and make them work?

I think they're pretty useless, tbh. There's too many buffers that just
printing them out is helpful - pg_buffercache is going to be a better
bet. When debugging issues where pg_buffercache isn't an option (e.g. because
it's a hang that doesn't allow running pg_buffercache), using
DebugPrintBufferRefcount() is much more targeted.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: New feature request for adding session information to PostgreSQL transaction log
Next
From: Michail Nikolaev
Date:
Subject: Re: Issue with markers in isolation tester? Or not?