Re: Calculate total_table_pages after set_base_rel_sizes() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Calculate total_table_pages after set_base_rel_sizes()
Date
Msg-id 8122.1541611077@sss.pgh.pa.us
Whole thread Raw
In response to Re: Calculate total_table_pages after set_base_rel_sizes()  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: Calculate total_table_pages after set_base_rel_sizes()
List pgsql-hackers
David Rowley <david.rowley@2ndquadrant.com> writes:
> [ v2-0001-Calculate-total_table_pages-after-set_base_rel_si.patch ]

Pushed with cosmetic adjustments.  The reason it's okay to not check for
appendrels in this loop is now quite different from the reason it was okay
before, so I didn't like the fact that you'd just cut-and-pasted the same
comment.  Also, you did s/brel/rel/ in the transferred code, which I would
not have objected to except you were inserting it into a function that
(a) already had a local variable "rel", causing a shadowing situation,
and (b) had an identical loop just above this that used the "brel"
notation.  So I changed that back.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: fix psql \conninfo & \connect when using hostaddr
Next
From: Peter Eisentraut
Date:
Subject: Re: file cloning in pg_upgrade and CREATE DATABASE