Re: Relation bulk write facility - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Relation bulk write facility
Date
Msg-id 820444.1708704361@sss.pgh.pa.us
Whole thread Raw
In response to Re: Relation bulk write facility  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> Thanks, the error message was clear enough:
>> bulk_write.c:78:3: error: redefinition of typedef 'BulkWriteState' is a C11 feature [-Werror,-Wtypedef-redefinition]
>> } BulkWriteState;

> Fixed now, but I'm a bit surprised other buildfarm members nor cirrus CI
> caught that. I also tried to reproduce it locally by adding
> -Wtypedef-redefinition, but my version of clang didn't produce any
> warnings. Are there any extra compiler options on those animals or
> something?

They use Apple's standard compiler (clang 15 or so), but

     'CC' => 'ccache clang -std=gnu99',

so maybe the -std has something to do with it.  I installed that
(or -std=gnu90 as appropriate to branch) on most of my build
setups back when we started the C99 push.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Relation bulk write facility
Next
From: Peter Eisentraut
Date:
Subject: Re: SQL Property Graph Queries (SQL/PGQ)