Re: Memory leak of SMgrRelation object on standby - Mailing list pgsql-hackers

From 邱宇航
Subject Re: Memory leak of SMgrRelation object on standby
Date
Msg-id 838F25BF-B10A-4A3E-94F9-1090E477615E@gmail.com
Whole thread Raw
In response to Re: Memory leak of SMgrRelation object on standby  (Jingtang Zhang <mrdrivingduck@gmail.com>)
Responses Re: Memory leak of SMgrRelation object on standby
List pgsql-hackers
> 2025年8月26日 11:59,Jingtang Zhang <mrdrivingduck@gmail.com> 写道:
>
> Hi~
>
>> I purpose a patch which calls smgrdestroyall() when redo each
>> XLOG_CHECKPOINT_ONLINE, so that it can keep the same frequency of calling
>> smgrdestroyall() as background processes on primary. I don't call it for
>> XLOG_CHECKPOINT_SHUTDOWN because the process is about to exit so that the
>> memory will go soon, and don't call it for XLOG_CHECKPOINT_REDO because it
>> seems to be a place holder only.
>
>
> Oops. When redo XLOG_CHECKPOINT_SHUTDOWN, smgrdestroyall should also be
> called, since the startup may not exit on standby.
>
> The patch is updated.
>
> —
> Regards, Jingtang
>
> <v4-0001-Fix-SMgrRelation-object-memory-leak-during-startup-r.patch>

LGTM.

Best regards,
Yuhang Qiu




pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Remove traces of long in dynahash.c
Next
From: Fujii Masao
Date:
Subject: Re: pg_restore --no-policies should not restore policies' comment