Re: Improve CRC32C performance on SSE4.2 - Mailing list pgsql-hackers

From Andy Fan
Subject Re: Improve CRC32C performance on SSE4.2
Date
Msg-id 877c19cpzs.fsf@163.com
Whole thread Raw
List pgsql-hackers
John Naylor <johncnaylorls@gmail.com> writes:

Hi,

>> Just be curious, what kind of optimization (like what -O2 does) could
>> mask this issue?
>
> In case Andy is asking about "how" rather than "under what
> circumstances", my guess is: -O1+  may have just chosen instructions
> that also happen to zero-extend, which are common. -O0 doesn't
> represent the naive straightforward structure of what the programmer
> wrote, it's more like an "exploded" representation suitable for later
> optimization passes. That's why it always looks goofy.

Thanks for the explaination!

>> > Replacing that with _mm512_zextsi128_si512 fixes the problem.
>
> Here's a patch for testing, which also reverts the previous
> workaround. Help welcome, but I still promise to test it in the near
> future regardless.

I verified the your patch, it works for me. 

-- 
Best Regards
Andy Fan




pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly
Next
From: Etsuro Fujita
Date:
Subject: Re: Avoid possible dereference null pointer (contrib/postgres_fdw/postgres_fdw.c)