Re: patch adding new regexp functions - Mailing list pgsql-patches

From Gregory Stark
Subject Re: patch adding new regexp functions
Date
Msg-id 87r6rihj23.fsf@stark.xeocode.com
Whole thread Raw
In response to Re: patch adding new regexp functions  (Jeremy Drake <pgsql@jdrake.com>)
Responses Re: patch adding new regexp functions
List pgsql-patches
"Jeremy Drake" <pgsql@jdrake.com> writes:

> BTW, should I be calling get_typlenbyvalalign on TEXTOID or are there macros
> for those also?

Hardcoding -1 for typlen of varlenas is one of the few (the only?) magic
constants used throughout the source code. I'm surprised there isn't a macro
for it though.

Do you need the alignment? If so I want to check the code against the packed
varlena patch. Just in case.


--
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com

pgsql-patches by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Win32 shmem
Next
From: Gregory Stark
Date:
Subject: Re: patch adding new regexp functions