Re: New function normal_rand_array function to contrib/tablefunc. - Mailing list pgsql-hackers

From Andy Fan
Subject Re: New function normal_rand_array function to contrib/tablefunc.
Date
Msg-id 87ses7rfc2.fsf@163.com
Whole thread Raw
In response to New function normal_rand_array function to contrib/tablefunc.  (Andy Fan <zhihuifan1213@163.com>)
Responses Re: New function normal_rand_array function to contrib/tablefunc.
List pgsql-hackers
Dean Rasheed <dean.a.rasheed@gmail.com> writes:

> On Wed, 16 Oct 2024 at 08:43, Andy Fan <zhihuifan1213@163.com> wrote:
>>
>>  Thanks for the detailed feedback! Here is the rebased version.
>>
>
> I took another look at this and I think it's in reasonable shape.
>
> I'm attaching an update, rebasing it on top of 9be4e5d293.

Thank you Dean. 

> Also it was missing a required update to the meson.build file --
> that's the immediate cause of the other cfbot failures.

OK, great to know this one, I should have paid more attention to cfbot. 

> The rest is just cosmetic tidying up, fixing indentation, tweaking
> comments, and the like. I also hacked on the docs a bit -- the
> synopsis only listed one of the new function signatures for some
> reason. After fixing that, I think it's sufficient to just list one
> usage example.

That looks better now, more concise and expressive sentences.

-- 
Best Regards
Andy Fan




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: What is a typical precision of gettimeofday()?
Next
From: Peter Smith
Date:
Subject: Re: Pgoutput not capturing the generated columns