Re: explain analyze rows=%.0f - Mailing list pgsql-hackers

Le sam. 11 janv. 2025 à 12:10, Ilia Evdokimov <ilya.evdokimov@tantorlabs.com> a écrit :

On 11.01.2025 12:15, Guillaume Lelarge wrote:

Thanks for your patch, this looks like a very interesting feature that I'd like to see in a future release.

It did a quick run: patch OK, make OK, make install OK, but make check fails quite a lot on partition_prune.sql.

I guess it would need some work on partition_prune.sql tests and perhaps also on the docs.

Thanks again.

--

Guillaume.

Yes, certainly. I have fixed partition_prune.sql. In the documentation example for EXPLAIN ANALYZE where loops is greater than one, I updated how 'rows' and 'loops' values are displayed so they appear as decimal fractions with two digits after the decimal point.

I attached fixed patch.

Any suggestions?

Thanks for the updated patch.

"make check" is happy, so no more suggestions, except you should register it in the next commitfest.

--

Guillaume.

Done!

https://commitfest.postgresql.org/52/5501/

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.