Re: str_casefold: fix typo in error message - Mailing list pgsql-hackers

From Chao Li
Subject Re: str_casefold: fix typo in error message
Date
Msg-id 9157875F-1B6D-4166-BB44-1B59A85C14B1@gmail.com
Whole thread Raw
In response to Re: str_casefold: fix typo in error message  (Steven Niu <niushiji@gmail.com>)
Responses Re: str_casefold: fix typo in error message
List pgsql-hackers

> On Jan 13, 2026, at 10:16, Steven Niu <niushiji@gmail.com> wrote:
>
> From: Chao Li <li.evan.chao@gmail.com>
> Sent: Tuesday, January 13, 2026 10:09
> To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
> Subject: str_casefold: fix typo in error message
>
> Hi Hacker,Found this issue while reviewing the other patch. That looks like a copy-paste error from the initial
commit.Bestregards,--Chao Li (Evan)HighGo Software Co., Ltd.https://www.highgo.com/ 
>
>
> Hi, Evan,
>
> I have a comment. Since it is collid that's being checked and will be used by function pg_newlocale_from_collation(),
soI think the change should be: 
>
> - "lower()"),
> + "pg_newlocale_from_collation(()"),
>
> thought?

If you look at other functions in the file, there is a pattern for what it should be. In this patch, I just want to fix
theerror without breaking the pattern. 

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Patch: dumping tables data in multiple chunks in pg_dump
Next
From: Tatsuo Ishii
Date:
Subject: Re: Row pattern recognition