Re: A small bug in gram.y - Mailing list pgsql-hackers

From Gokulakannan Somasundaram
Subject Re: A small bug in gram.y
Date
Msg-id 9362e74e0911022221n11394432v96cd5302adbacbca@mail.gmail.com
Whole thread Raw
In response to A small bug in gram.y  (Gokulakannan Somasundaram <gokul007@gmail.com>)
Responses Re: A small bug in gram.y
List pgsql-hackers
Hmmm.... no-one else feels this as a bug????

The logic is that a function call is made for "similar" and the position where SIMILAR occurs is at the third position, but it has been coded that it is at fifth position. 

Thanks,
Gokul.

On Tue, Oct 27, 2009 at 6:51 AM, Gokulakannan Somasundaram <gokul007@gmail.com> wrote:
Hi,
   In the gram.y, under a_expr rule
   under the subrule "a_expr NOT SIMILAR TO a_expr            %prec SIMILAR"
   the action is as follows
   {
                    FuncCall *n = makeNode(FuncCall);
                    n->funcname = SystemFuncName("similar_escape");
                    n->args = list_make2($5, makeNullAConst(-1));
                    n->agg_star = FALSE;
                    n->agg_distinct = FALSE;
                    n->func_variadic = FALSE;
                    n->over = NULL;
                    n->location = @5;
                    $$ = (Node *) makeSimpleA_Expr(AEXPR_OP, "!~", $1, (Node *) n, @2);
    }

     I think the n->location should be @3.

Thanks,
Gokul.

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: per-tablespace random_page_cost/seq_page_cost
Next
From: Heikki Linnakangas
Date:
Subject: Re: A small bug in gram.y