Re: Safeguards against incorrect fd flags for fsync() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Safeguards against incorrect fd flags for fsync()
Date
Msg-id 947174.1749604175@sss.pgh.pa.us
Whole thread Raw
In response to Safeguards against incorrect fd flags for fsync()  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> We don't have a trace of O_ACCMODE in the tree, and POSIX defines it.
> I'm wondering how the buildfarm would react on that, but perhaps
> that's fine on !WIN32.  It's hard to say with all the hosts there, at
> least the CI is OK.

POSIX has required O_ACCMODE in fcntl.h at least since 2008,
if I'm reading things correctly.  So it's probably safe to
depend on this symbol.  Still, I'd like to be closer to having
a working Hurd buildfarm member before we take a portability
risk that would only benefit Hurd.

> Another thing that may be worth considering is if we should remove
> this sanity check.

Nah.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: queryId constant squashing does not support prepared statements
Next
From: Naga Appani
Date:
Subject: Re: [PATCH v1] Add pg_stat_multixact view for multixact membership usage monitoring